Skip to content

[WIP] Added an option to open a folder in VSCode#414

Draft
adriengivry wants to merge 9 commits intomainfrom
feature/open_in_vscode
Draft

[WIP] Added an option to open a folder in VSCode#414
adriengivry wants to merge 9 commits intomainfrom
feature/open_in_vscode

Conversation

@adriengivry
Copy link
Member

@adriengivry adriengivry commented Mar 29, 2025 •
edited
Loading

Description

  • Added an option to open a folder in an external tool (Visual Studio Code or anything else!).
  • Instead of adding a button to the menu bar (suggested by Add a button to the menu bar to open the project in VS code #389), I added an option to any folder's contextual menu.
  • Added EditorSettings entries for custom external tool name and command
  • Added ExternalTools utility to define the presets
  • Added setting to "Menu Bar" to select an external tool preset, or use a custom one.

Related Issues

Closes #389

Screenshot

image

OvEditor_LhBb2tkJmL.mp4

@adriengivry adriengivry added QoL Quality of Life : Something that can improve users productivity Feature Editor Something relative with the editor labels Mar 29, 2025
@adriengivry adriengivry self-assigned this Mar 29, 2025
@adriengivry adriengivry force-pushed the feature/open_in_vscode branch from a82a007 to e6f695a Compare March 29, 2025 15:50
litelawliet
litelawliet requested changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@litelawliet litelawliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Release, when opening a folder in VS Code (example), a command-line terminal will open in order to launch the external tool. Keeping the external tool open and opening again a folder from Overload will not create another command-line terminal.
However if you close the external tool prior to open again another folder then a command-line terminal will be created again.

This doesn't happen in Debug because a terminal is attached to Overload, but since no terminal is attached in Release it then have to create one in order to run the command-line that open an external tool.

I think we should hide (set to background the terminal) when running the command line for an external tool.

@adriengivry adriengivry force-pushed the feature/open_in_vscode branch from e6f695a to 086f45a Compare March 31, 2025 16:51
@adriengivry
Copy link
Member Author

adriengivry commented Mar 31, 2025

In Release, when opening a folder in VS Code (example), a command-line terminal will open in order to launch the external tool. Keeping the external tool open and opening again a folder from Overload will not create another command-line terminal. However if you close the external tool prior to open again another folder then a command-line terminal will be created again.

This doesn't happen in Debug because a terminal is attached to Overload, but since no terminal is attached in Release it then have to create one in order to run the command-line that open an external tool.

I think we should hide (set to background the terminal) when running the command line for an external tool.

Fixed! ✅ 086f45a

@adriengivry adriengivry requested a review from litelawliet March 31, 2025 16:51
@adriengivry
Copy link
Member Author

adriengivry commented Mar 31, 2025 •
edited
Loading

Putting this one back to draft, it's currently not possible to know, using cmd.exe /c if the underlying command succeeded (code, subl, or atom), therefore, the current solution isn't satisfactory.

@litelawliet for vis.

@adriengivry adriengivry marked this pull request as draft March 31, 2025 18:48
@adriengivry adriengivry changed the title Added an option to open a folder in VSCode [WIP] Added an option to open a folder in VSCode May 9, 2025
@adriengivry adriengivry mentioned this pull request Nov 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxbrundev maxbrundev Awaiting requested review from maxbrundev

@litelawliet litelawliet Awaiting requested review from litelawliet

Requested changes must be addressed to merge this pull request.

Assignees

@adriengivry adriengivry

Labels

Editor Something relative with the editor QoL Quality of Life : Something that can improve users productivity

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a button to the menu bar to open the project in VS code

2 participants

@adriengivry @litelawliet